-
Notifications
You must be signed in to change notification settings - Fork 127
314 minor fixes for guides #2371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f5ca9ec
minor edits, link fixes for api quickstarts
ketkee-aryamane 3c9a389
minor fixes
ketkee-aryamane 2042790
fix formatting
ketkee-aryamane e941e9b
update Learn more section
ketkee-aryamane 31cc04e
minor rephrase in Learn more
ketkee-aryamane 86bd727
Merge branch 'main' into 314-minor-fixes-for-guides
ketkee-aryamane e39b752
Update solutions/search/elasticsearch-basics-quickstart.md
ketkee-aryamane 5462a8b
Update solutions/search/elasticsearch-basics-quickstart.md
ketkee-aryamane c4d863c
Update solutions/search/elasticsearch-basics-quickstart.md
ketkee-aryamane 178c9da
Update solutions/search/elasticsearch-basics-quickstart.md
ketkee-aryamane 936e431
Update solutions/search/elasticsearch-basics-quickstart.md
ketkee-aryamane 2d8c405
fix review feedback
ketkee-aryamane f0559d1
Update solutions/search/esql-search-tutorial.md
ketkee-aryamane c3cfc80
fix review feedback
ketkee-aryamane 5ac17db
minor edits
ketkee-aryamane 1ea3c49
Update solutions/search/esql-search-tutorial.md
ketkee-aryamane bf15bb0
fix broken links
ketkee-aryamane b967feb
Merge remote-tracking branch 'origin/314-minor-fixes-for-guides' into…
ketkee-aryamane ced45f9
Update solutions/search/querydsl-full-text-filter-tutorial.md
ketkee-aryamane 77d3cdd
Merge branch 'main' into 314-minor-fixes-for-guides
ketkee-aryamane f79227b
Merge branch 'main' into 314-minor-fixes-for-guides
ketkee-aryamane 8d65795
Update solutions/search/elasticsearch-basics-quickstart.md
ketkee-aryamane e2f71c7
Merge branch 'main' into 314-minor-fixes-for-guides
ketkee-aryamane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure we want to delete these, the syntax was used to maintain IDs in migration but if there isn't any CI errors, I guess it's OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. After I removed those, the broken links for those titles started working too. Let me know if we need to confirm about this from someone else too.