Skip to content

[EDOT][windows] add missing samples for windows #10728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2025
Merged

[EDOT][windows] add missing samples for windows #10728

merged 4 commits into from
Oct 27, 2025

Conversation

@VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Oct 23, 2025 •
edited
Loading

Add sample config files for Windows ES and mOTLP ingestion, to achieve parity with other platforms.

Fixes #10540

@VihasMakwana VihasMakwana self-assigned this Oct 23, 2025
@VihasMakwana VihasMakwana added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 23, 2025
@VihasMakwana VihasMakwana requested review from a team as code owners October 23, 2025 06:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@VihasMakwana VihasMakwana added the backport-active-all Automated backport with mergify to all the active branches label Oct 23, 2025
@VihasMakwana VihasMakwana changed the title [EDOT][windows] add missing samples and changelog [EDOT][windows] add missing samples for windows Oct 23, 2025
theletterf
theletterf previously approved these changes Oct 23, 2025
View reviewed changes
@theletterf
Copy link
Contributor

Thanks! OK from my side. I guess we still need a tech review though.

@VihasMakwana
Copy link
Contributor Author

@theletterf looks like CI is flaky. I'll ping you to approve again once it gets green.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @VihasMakwana

@VihasMakwana
Copy link
Contributor Author

@theletterf this looks good to go. Can you please approve again?

rogercoll
rogercoll approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configurations looks good to me. I would recommend a review from @elastic/elastic-agent-control-plane as it would be best to have some kind of integration tests for these samples

swiatekm
swiatekm approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have tests for config samples, and adding them is probably significant additional effort, so it shouldn't block this PR.

@VihasMakwana VihasMakwana merged commit 03a81c0 into elastic:main Oct 27, 2025
21 checks passed
@github-actions
Copy link
Contributor

@Mergifyio backport 8.19 9.0 9.1 9.2

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2025 •
edited
Loading

backport 8.19 9.0 9.1 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 27, 2025
@VihasMakwana @mergify
[EDOT][windows] add missing samples for windows (#10728)
9786d66 
* add docs and changelog

* remove redundant

(cherry picked from commit 03a81c0)
mergify bot pushed a commit that referenced this pull request Oct 27, 2025
@VihasMakwana @mergify
[EDOT][windows] add missing samples for windows (#10728)
453abd3 
* add docs and changelog

* remove redundant

(cherry picked from commit 03a81c0)
@mergify mergify bot mentioned this pull request Oct 27, 2025
Open
@mergify mergify bot mentioned this pull request Oct 27, 2025
Merged
mergify bot pushed a commit that referenced this pull request Oct 27, 2025
@VihasMakwana @mergify
[EDOT][windows] add missing samples for windows (#10728)
a0a3c78 
* add docs and changelog

* remove redundant

(cherry picked from commit 03a81c0)
@mergify mergify bot mentioned this pull request Oct 27, 2025
Open
mergify bot pushed a commit that referenced this pull request Oct 27, 2025
@VihasMakwana @mergify
[EDOT][windows] add missing samples for windows (#10728)
ff52ef6 
* add docs and changelog

* remove redundant

(cherry picked from commit 03a81c0)
@mergify mergify bot mentioned this pull request Oct 27, 2025
Open
VihasMakwana added a commit that referenced this pull request Oct 27, 2025
@mergify @VihasMakwana
[EDOT][windows] add missing samples for windows (#10728) (#10853)
f4c3532 
* add docs and changelog

* remove redundant

(cherry picked from commit 03a81c0)

Co-authored-by: Vihas Makwana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theletterf theletterf theletterf approved these changes

@rogercoll rogercoll rogercoll approved these changes

@swiatekm swiatekm swiatekm approved these changes

Assignees

@VihasMakwana VihasMakwana

Labels

backport-active-all Automated backport with mergify to all the active branches docs Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing Windows configuration sample files

5 participants

@VihasMakwana @elasticmachine @theletterf @rogercoll @swiatekm