[9.1] (backport #10681) [Helm charts] Properly quote boolean values #10860
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
blakerouse and
pkoutsovasilis
and removed request for
a team
8 tasks
github-actions
bot
added
bug
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
ycombinator
approved these changes
Oct 27, 2025
* Properly quote boolean values in Helm charts * Adding CHANGELOG fragment (cherry picked from commit 815dd3e)
ycombinator
force-pushed
the
mergify/bp/9.1/pr-10681
branch
from
b9f68fd to
b2b329d
Compare
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @ycombinator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the quoting of boolean values
agent.fleet.insecureandagent.fleet.force.Why is it important?
Prior to the fix, the rendered values for these fields would appear like so, with an extra pair of quotes, which was causing the rendered value to be ineffective:
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testDisruptive User Impact
None; fixes a bug.
How to test this PR locally
insecure: truehere.mage helm:renderExamplesThanks @pkoutsovasilis for suggesting the fix and testing steps.
This is an automatic backport of pull request #10681 done by Mergify.