Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 3, 2025

This PR updates the Duration type to include an external doc link to https://www.elastic.co/docs/reference/elasticsearch/rest-apis/api-conventions#time-units, which describes the supported time units.

This results in the addition of the link to all the places where that Duration type is used, for example:

image

Copy link
Contributor

github-actions bot commented Oct 3, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 21acd77 into main Oct 6, 2025
12 checks passed
@lcawl lcawl deleted the duration-externalDocs branch October 6, 2025 17:40
Copy link
Contributor

github-actions bot commented Oct 6, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5409-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21acd7707a037fb9800f3f0e4e2695f8e8af3daa
# Push it to GitHub
git push --set-upstream origin backport-5409-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5409-to-8.19.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5409-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21acd7707a037fb9800f3f0e4e2695f8e8af3daa
# Push it to GitHub
git push --set-upstream origin backport-5409-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5409-to-9.0.

github-actions bot pushed a commit that referenced this pull request Oct 6, 2025
github-actions bot pushed a commit that referenced this pull request Oct 6, 2025
lcawl added a commit that referenced this pull request Oct 6, 2025
lcawl added a commit that referenced this pull request Oct 6, 2025
lcawl added a commit that referenced this pull request Oct 6, 2025
lcawl added a commit that referenced this pull request Oct 6, 2025
@lcawl
Copy link
Contributor Author

lcawl commented Oct 6, 2025

💚 All backports created successfully

Status Branch Result
9.0
8.19

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Oct 6, 2025
lcawl added a commit that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants