Skip to content

Add project_routing param to _project/tags #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2025
Merged

Add project_routing param to _project/tags #5730

merged 3 commits into from
Nov 25, 2025
+98 −20

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Nov 24, 2025

@smalyshev smalyshev requested a review from a team as a code owner November 24, 2025 23:21
@smalyshev smalyshev requested a review from quux00 November 24, 2025 23:22
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025 •
edited
Loading

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
connector.secret_delete 🟠 → 🟢 Missing type → 4/4 Missing type → 4/4
connector.secret_get 🟠 → 🟢 Missing type → 11/11 Missing type → 11/11
connector.secret_post 🟠 → 🟢 Missing type → 9/9 Missing type → 9/9
connector.secret_put 🟠 → 🟢 Missing type → 4/4 Missing type → 4/4
fleet.delete_secret 🟠 → ⚪ Missing type → Missing test Missing type → Missing test
fleet.get_secret 🟠 → ⚪ Missing type → Missing test Missing type → Missing test
fleet.post_secret 🟠 → ⚪ Missing type → Missing test Missing type → Missing test

You can validate these APIs yourself by using the make validate target.

quux00
quux00 requested changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested change in the project_routing description.

specification/_json_spec/project.tags.json Outdated
"params": {
"project_routing": {
"type": "string",
"description": "A Lucene query using project metadata tags to limit which projects to search, such as _alias:_origin or _alias:*pr*."
Copy link
Contributor

@quux00 quux00 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this endpoint, this description (which you probably grabbed from the other endpoints) is misleading, since this usage is different and doesn't actually search linked projects.

So I would like something (for this endpoint only) more like:

A Lucene query using project metadata tags used to filter which projects are returned in the response, such as ...

Copy link
Contributor Author

@smalyshev smalyshev Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@smalyshev smalyshev requested a review from quux00 November 25, 2025 20:57
quux00
quux00 approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smalyshev smalyshev added the skip-backport This pull request should not be backported label Nov 25, 2025
@smalyshev smalyshev merged commit bcc1230 into main Nov 25, 2025
11 of 12 checks passed
@smalyshev smalyshev deleted the project_routing branch November 25, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quux00 quux00 quux00 approved these changes

Assignees

No one assigned

Labels

serverless skip-backport This pull request should not be backported specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smalyshev @quux00