Skip to content

Conversation

limotova
Copy link
Contributor

@limotova limotova commented Jul 11, 2025

This commit adds in Min/MaxOverTime CSV tests for all supported types
and introduces a new CSV dataset representing a downsampled version of
the existing k8s CSV dataset.

@limotova limotova force-pushed the add-max-min-over-time-csv-tests branch 11 times, most recently from cf85ceb to 596ad25 Compare July 18, 2025 04:42
@limotova limotova force-pushed the add-max-min-over-time-csv-tests branch 6 times, most recently from b1c6e47 to 467a3a2 Compare July 20, 2025 01:06
@limotova
Copy link
Contributor Author

limotova commented Jul 25, 2025

Blocked on #131658 <-- Merged

@limotova limotova force-pushed the add-max-min-over-time-csv-tests branch from 2daeb98 to e4ae562 Compare July 26, 2025 03:44
@limotova limotova changed the title Add more Min/MaxOverTime CSV tests [ES|QL] Add more Min/MaxOverTime CSV tests Jul 26, 2025
@limotova limotova force-pushed the add-max-min-over-time-csv-tests branch from e4ae562 to 1c57a5b Compare July 26, 2025 04:32
This commit adds in Min/MaxOverTime CSV tests for all supported types
and introduces a new csv dataset representing a downsampled version of
the existing k8s csv dataset.
@limotova limotova force-pushed the add-max-min-over-time-csv-tests branch from 1c57a5b to 519b7e3 Compare July 26, 2025 04:36
@limotova limotova added >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics :Analytics/ES|QL AKA ESQL labels Jul 26, 2025
@limotova limotova marked this pull request as ready for review July 26, 2025 09:10
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks Larisa!

/**
* Extra field types in the k8s.csv dataset
*/
K8S_DATASET_ADDITIONAL_FIELDS(Build.current().isSnapshot()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we don't need a new capability for this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do for the serverless tests, it's not all of the tests but the ones that used the new fields were failing there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for explaining.

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding these tests.

@limotova limotova merged commit 161dd69 into elastic:main Jul 28, 2025
35 checks passed
@limotova limotova deleted the add-max-min-over-time-csv-tests branch July 28, 2025 18:43
szybia added a commit to szybia/elasticsearch that referenced this pull request Jul 29, 2025
…-tracking

* upstream/main: (26 commits)
  Add release notes for v9.1.0 release (elastic#131953)
  Unmute multi_node generative tests (elastic#132021)
  Avoid re-enqueueing merge tasks (elastic#132020)
  Fix file entitlements for shared data dir (elastic#131748)
  ES|QL brute force l2_norm vector function (elastic#132025)
  Make ES|QL SAMPLE not a pipeline breaker (elastic#132014)
  Speed up tail computation in MemorySegmentES91OSQVectorsScorer (elastic#132001)
  Remove deprecated usages in `TransportPutFollowAction` (elastic#132038)
  Simulate impact of shard movement using shard-level write load (elastic#131406)
  Remove RemoteClusterService.getConnections() method (elastic#131948)
  Fix off by one in ValuesBytesRefAggregator (elastic#132032)
  Use unicode strings in data generation by default (elastic#132028)
  Adding index.refresh_interval as a data stream setting (elastic#131482)
  [ES|QL] Add more Min/MaxOverTime CSV tests (elastic#131070)
  Restrict remote ENRICH after FORK (elastic#131945)
  Fix decoding of non-ascii field names in ignored source (elastic#132018)
  [docs] Use centrally maintained version variables (elastic#131939)
  Configurable Inference timeout during Query time (elastic#131551)
  ESQL: Allow pruning columns added by InlineJoin (elastic#131204)
  ESQL: Fail `profile` on text response formats (elastic#128627)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants