Skip to content

Enable failure store for log data streams #131261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 31, 2025
Merged

Enable failure store for log data streams #131261

merged 24 commits into from
Jul 31, 2025

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jul 15, 2025 •
edited
Loading

Closes #131105
Now let's see which tests this breaks 🙂

@eyalkoren eyalkoren requested a review from felixbarny July 15, 2025 03:38
@eyalkoren eyalkoren self-assigned this Jul 15, 2025
@eyalkoren eyalkoren added >feature :Data Management/Data streams Data streams and their lifecycles v9.2.0 labels Jul 15, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jul 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @eyalkoren, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jul 15, 2025
@eyalkoren eyalkoren mentioned this pull request Jul 15, 2025
Merged
dakrone
dakrone approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to have the StackTemplateRegistry#REGISTRY_VERSION number bumped, but otherwise looks good to me. I left a couple of minor comments, but looks fine after CI passes.

@eyalkoren eyalkoren mentioned this pull request Jul 20, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

Hi @eyalkoren, I've updated the changelog YAML for you. Note that since this PR is labelled release highlight, you need to update the changelog YAML to fill out the extended information sections.

felixbarny
felixbarny reviewed Jul 25, 2025
View reviewed changes
@eyalkoren eyalkoren requested a review from mosche July 29, 2025 07:21
@eyalkoren
Copy link
Contributor Author

@mosche please see 10af65e, which includes the change we discussed. Thanks for your assistance! 🙏

mosche
mosche approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for switching to test features, that part lgtm

@eyalkoren eyalkoren merged commit 3eab53c into elastic:main Jul 31, 2025
33 checks passed
@eyalkoren eyalkoren deleted the logs-enable-faliure-store branch July 31, 2025 05:10
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Jul 31, 2025
@eyalkoren @afoucret
Enable failure store for log data streams (elastic#131261)
a206857
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jul 31, 2025
@eyalkoren @smalyshev
Enable failure store for log data streams (elastic#131261)
572e8fb
@jen-huang jen-huang mentioned this pull request Aug 15, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixbarny felixbarny felixbarny approved these changes

@dakrone dakrone dakrone approved these changes

@mosche mosche mosche approved these changes

Assignees

@eyalkoren eyalkoren

Labels
:Data Management/Data streams Data streams and their lifecycles >feature release highlight serverless-linked Added by automation, don't add manually Team:Data Management Meta label for data/management team v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable failure store for logs by default
6 participants
@eyalkoren @elasticsearchmachine @dakrone @mosche @felixbarny @LucaWintergerst