Skip to content

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 18, 2025

When only one segment remains for scanning, we can avoid moving the only segment iterator between the main queue and the sub-queue. This optimized path should also work with a forced-merge shard.

@dnhatn dnhatn added :StorageEngine/TSDB You know, for Metrics >non-issue labels Jul 18, 2025
@dnhatn dnhatn requested a review from kkrik-es July 18, 2025 06:46
@dnhatn dnhatn marked this pull request as ready for review July 18, 2025 06:47
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn dnhatn mentioned this pull request Jul 18, 2025
28 tasks
Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, consider adding a test if we don't have coverage.

@dnhatn
Copy link
Member Author

dnhatn commented Jul 18, 2025

Thanks Kostas! We should have good test coverage for this operator in TimeSeriesSourceOperatorTests.

@dnhatn dnhatn merged commit 0f00f69 into elastic:main Jul 18, 2025
33 checks passed
@dnhatn dnhatn deleted the ts-source-single-segment-path branch July 18, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants