-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Refresh potential lost connections at query start for field caps #131517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh potential lost connections at query start for field caps #131517
Conversation
others as top-level errors
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Hi @pawankartik-elastic, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two open questions left.
server/src/main/java/org/elasticsearch/action/fieldcaps/TransportFieldCapabilitiesAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/fieldcaps/TransportFieldCapabilitiesAction.java
Show resolved
Hide resolved
...ClusterTest/java/org/elasticsearch/indices/cluster/RemoteFieldCapsForceConnectTimeoutIT.java
Outdated
Show resolved
Hide resolved
...ClusterTest/java/org/elasticsearch/indices/cluster/RemoteFieldCapsForceConnectTimeoutIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work here!
For CPS S2D9, we'd need field caps to refresh potentially lost connections at start: by explicitly establishing a connection with a short timeout to avoid waiting for large duration. This is similar to what we recently did with
_search
and will help for ES|QL as well.