Skip to content

Change ThreadPoolUsage from single to list of samples #131738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change ThreadPoolUsage from single to list of samples #131738

wants to merge 2 commits into from

Conversation

mhl-b
Copy link
Contributor

@mhl-b mhl-b commented Jul 23, 2025 •
edited
Loading

  • Change ThreadPoolUsageCollector response from a single to list of samples.
  • Add thread-pool-name argument to ThreadPoolUsageCollector. Currently we use only write-thread-pool.
  • Rename generic NodeUsageStatsForThreadPools to specific writeThreadPoolUsages, since it's the only use case for now. There were inconsistencies when we call NodeUsageStatsForThreadPools but assumed only write-thread-pool.
  • Remove hash, equals, toString from records ThreadPoolUsage and ThreadPoolUsage.Sample.

@mhl-b mhl-b added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Jul 23, 2025
@mhl-b mhl-b requested a review from a team as a code owner July 23, 2025 00:10
@mhl-b mhl-b added Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0 labels Jul 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@mhl-b mhl-b mentioned this pull request Jul 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktindall nicktindall Awaiting requested review from nicktindall

@DiannaHohensee DiannaHohensee Awaiting requested review from DiannaHohensee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhl-b @elasticsearchmachine