-
Notifications
You must be signed in to change notification settings - Fork 25.5k
[TEST] Adds tests for ESTestCase randomSubset methods #131745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshua-adams-1
merged 8 commits into
elastic:main
from
joshua-adams-1:extend-es-test-case
Jul 28, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
57c528d
[TEST] Adds tests for ESTestCase randomSubset methods
joshua-adams-1 73ec761
Amend names
joshua-adams-1 da73b00
Randomizes the tests
joshua-adams-1 2044927
Merge branch 'main' into extend-es-test-case
joshua-adams-1 1c8b60f
Remove unused import
joshua-adams-1 665b13b
Ran Spotless Apply
joshua-adams-1 abc4581
Fix bug
joshua-adams-1 e902b41
Merge branch 'main' into extend-es-test-case
joshua-adams-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We could also randomize the list length of
10
. The same goes for other places where we construct the initial list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 10 parameter is actually the maximum list size, not the hardcoded list size. The
randomList
function randomises the length between 0 and this value inclusively. I could have randomised this size too, but I figured hardcoding a max list size was acceptable, because even if I randomised it, I would still have to declare a max value somewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. Sounds good to me.