Skip to content

Remove Transport Version from Serialization #131750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joshua-adams-1
Copy link
Contributor

Removes conditional statements from the NodeBalanceStats readFrom and writeTo methods that serialised depending on TransportVersions .V_8_8_0 and TransportVersions.V_8_12_0 since these transport versions are old and can be removed.

Jira: ES-10337

Removes conditional statements from the `NodeBalanceStats` `readFrom`
and `writeTo` methods that serialised depending on `TransportVersions
.V_8_8_0` and `TransportVersions.V_8_12_0` since these transport
versions are old and can be removed.

Jira: ES-10337
@joshua-adams-1 joshua-adams-1 self-assigned this Jul 23, 2025
@joshua-adams-1 joshua-adams-1 added >non-issue :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. and removed v9.2.0 labels Jul 23, 2025
@joshua-adams-1 joshua-adams-1 requested a review from ywangd July 23, 2025 12:47
@joshua-adams-1 joshua-adams-1 marked this pull request as ready for review July 23, 2025 12:47
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Jul 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good cleanup!

@joshua-adams-1 joshua-adams-1 merged commit 10fe741 into elastic:main Jul 24, 2025
33 checks passed
@joshua-adams-1 joshua-adams-1 deleted the cluster-balance-stats-transport-version branch July 24, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants