Skip to content

Build Tasks to Find and Verify TransportVersion Definitions #131782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 1, 2025
Merged

Build Tasks to Find and Verify TransportVersion Definitions #131782

merged 27 commits into from
Aug 1, 2025

Conversation

JVerwolf
Copy link
Contributor

@JVerwolf JVerwolf commented Jul 23, 2025 •
edited by jira bot
Loading

This PR introduces a set of build tasks to find and verify TransportVersion definitions using the new model.

This includes:

  1. A task to locate all transport version declarations of the form TransportVersion.fromName("some_name");, and record all the String literal arguments in a build file.
  2. A task to verify that all TransportVersion declarations have a corresponding data file
  3. A task to verify that all TransportVersion data files have a corresponding declaration
  4. A task to produce a manifest file that contains the filenames of all data files, for later use in a getResources call.

A subsequent PR will introduce a task to generate the data files.

Jiras:
ES-12335
ES-12336
ES-12398
ES-12338

@JVerwolf JVerwolf changed the title [WIP] Add task to scan for TV instantiations Build Tasks to Find and Verify TransportVersion Definitions Jul 25, 2025
@JVerwolf JVerwolf requested a review from a team July 25, 2025 20:41
@JVerwolf JVerwolf added auto-backport Automatically create backport pull requests when merged v8.18.0 v9.1.1 labels Jul 25, 2025
@JVerwolf JVerwolf requested a review from mark-vieira July 25, 2025 20:43
@JVerwolf JVerwolf marked this pull request as ready for review July 25, 2025 20:45
@JVerwolf JVerwolf requested a review from a team as a code owner July 25, 2025 20:45
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jul 25, 2025
mark-vieira
mark-vieira reviewed Jul 25, 2025
View reviewed changes
@rjernst rjernst added >refactoring :Delivery/Build Build or test infrastructure and removed >enhancement labels Jul 29, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team labels Jul 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jdconrad
Copy link
Contributor

@elasticmachine run elasticsearch-ci/bwc-snapshots-part3

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jul 31, 2025
jdconrad
jdconrad approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rjernst rjernst merged commit 4856d35 into elastic:main Aug 1, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 9.1 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131782

szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 1, 2025
@szybia
Merge remote-tracking branch 'upstream/main' into index-templates-tra…
08aec70 
…cking

* upstream/main: (166 commits)
  Reduce inactive sink interval in VectorSimilarityFunctionsIT (elastic#132288)
  ESQL: Allow agg tests to process many columns (elastic#132358)
  Update analysis-lowercase-tokenfilter.md (elastic#132359)
  Add Sparse Vector Index Options Settings to Semantic Text Field (elastic#131058)
  Collect node thread pool usage for shard balancing (elastic#131480)
  Add tasks to validate new style transport versions (elastic#131782)
  Mute org.elasticsearch.search.routing.SearchReplicaSelectionIT testNodeSelection elastic#132354
  Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryIT testBadAsyncId elastic#132353
  Fixes DenseVectorFieldIndexTypeUpdateIT release tests (elastic#132346)
  Fix testCloseOrReallocateDuringPartialSnapshot (elastic#132049)
  (Doc) ILM Force Merge not on HDD and happens on hosting node not current phase tier (elastic#130280)
  Run GeoIp YAML tests in multi-project cluster and fix bug discovered by tests (elastic#131521)
  Unmutes elastic#132111, seems a transient, non reproducible issue (elastic#132253)
  Mute org.elasticsearch.search.suggest.phrase.PhraseSuggesterIT testPhraseSuggestionWithNgramOnlyAnalyzerThrowsException elastic#132347
  Add AI21 support to Inference Plugin (elastic#131238)
  OpenJDK EA builds should use https instead of http (elastic#132297)
  ESQL: Normalize timeseries aggs slightly (elastic#132284)
  Avoid internal server error on suggester ngram bad request (elastic#132321)
  [ES|QL] Rerank operator improvements (elastic#132318)
  Mute org.elasticsearch.xpack.logsdb.qa.LogsDbVersusReindexedLogsDbChallengeRestIT testTermsQuery elastic#132337
  ...
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Aug 11, 2025
@JVerwolf @rjernst
Add tasks to validate new style transport versions (elastic#131782)
102e077 
This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: Ryan Ernst <[email protected]>
Co-authored-by: John Verwolf <[email protected]>
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Aug 11, 2025
@JVerwolf @rjernst
Add tasks to validate new style transport versions (elastic#131782)
58c91dd 
This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: Ryan Ernst <[email protected]>
Co-authored-by: John Verwolf <[email protected]>
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Aug 11, 2025
@JVerwolf @rjernst
Add tasks to validate new style transport versions (elastic#131782)
243ae21 
This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: Ryan Ernst <[email protected]>
Co-authored-by: John Verwolf <[email protected]>
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Aug 11, 2025
@JVerwolf @rjernst
Add tasks to validate new style transport versions (elastic#131782)
c78220c 
This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: Ryan Ernst <[email protected]>
Co-authored-by: John Verwolf <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Aug 11, 2025
@rjernst @JVerwolf
Add tasks to validate new style transport versions (#131782) (#132642)
ca1a702 
This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: John Verwolf <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Aug 11, 2025
@rjernst @JVerwolf
Add tasks to validate new style transport versions (#131782) (#132643)
158ccf2 
* Add tasks to validate new style transport versions (#131782)

This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: Ryan Ernst <[email protected]>
Co-authored-by: John Verwolf <[email protected]>

* skip if no named constants yet

* [CI] Auto commit changes from spotless

* don't actually set it if it doesn't exist

---------

Co-authored-by: John Verwolf <[email protected]>
Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Aug 11, 2025
@rjernst @JVerwolf
Add tasks to validate new style transport versions (#131782) (#132647)
f09d47f 
* Add tasks to validate new style transport versions (#131782)

This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: Ryan Ernst <[email protected]>
Co-authored-by: John Verwolf <[email protected]>

* skip if no named constants yet

* [CI] Auto commit changes from spotless

* temporarily add leniency for definitions dir

* [CI] Auto commit changes from spotless

---------

Co-authored-by: John Verwolf <[email protected]>
Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Aug 11, 2025
@rjernst @JVerwolf
Add tasks to validate new style transport versions (#131782) (#132645)
b65feee 
This commit adds new gradle plugins and tasks to handle validation of file based transport version definitions.

Co-authored-by: John Verwolf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst left review comments

@mark-vieira mark-vieira mark-vieira left review comments

@jdconrad jdconrad jdconrad approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Core Core issues without another label :Delivery/Build Build or test infrastructure >refactoring serverless-linked Added by automation, don't add manually Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team v8.18.0 v8.19.1 v9.0.5 v9.1.1 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JVerwolf @elasticsearchmachine @jdconrad @rjernst @mark-vieira