[8.19] [ES|QL] Change equals and hashcode for ConstantNullBlock (#131817) #131893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Currently in ES|QL if you have a ConstantNullBlock and a DoubleBlock (or any other standard block type: Boolean, BytesRef, Float, Int, Long) and your DoubleBlock can be represented as a ConstantNullBlock, then `doubleBlock.equals(constantNullBlock)` can evaluate as `true` (if position count is the same). However, `constantNullBlock.equals(anyDoubleBlock)` is always false. Likewise, the hashcodes of these two blocks are different, even if `doubleBlock.equals(constantNullBlock)` returns true. This PR addresses that by making the hashcodes equivalent and the equals functions symmetric in returning true.
limotova
added
:Analytics/ES|QL
limotova
added a commit
to limotova/elasticsearch
that referenced
this pull request
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.19: