Skip to content

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jul 29, 2025

If we combined two BulkResponses with ingest_took set to NO_INGEST_TOOK we'd get an ingest_took of -2. Which doesn't make any sense. This fixes it to be set to NO_INGEST_TOOK properly.

If we combined two `BulkResponse`s with `ingest_took` set to
`NO_INGEST_TOOK` we'd get an `ingest_took` of `-2`. Which doesn't make
any sense. This fixes it to be set to `NO_INGEST_TOOK` properly.
@nik9000 nik9000 requested a review from martijnvg July 29, 2025 14:31
@nik9000 nik9000 added >bug auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.2.0 v9.1.1 v8.19.1 labels Jul 29, 2025
@nik9000
Copy link
Member Author

nik9000 commented Jul 29, 2025

I hit this when indexing 5mb documents for the HeapAttackIT.

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @nik9000, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx Nik!

@nik9000 nik9000 merged commit d3f47c6 into elastic:main Jul 31, 2025
33 checks passed
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 31, 2025
If we combined two `BulkResponse`s with `ingest_took` set to
`NO_INGEST_TOOK` we'd get an `ingest_took` of `-2`. Which doesn't make
any sense. This fixes it to be set to `NO_INGEST_TOOK` properly.
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jul 31, 2025
If we combined two `BulkResponse`s with `ingest_took` set to
`NO_INGEST_TOOK` we'd get an `ingest_took` of `-2`. Which doesn't make
any sense. This fixes it to be set to `NO_INGEST_TOOK` properly.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
8.19

elasticsearchmachine pushed a commit that referenced this pull request Jul 31, 2025
If we combined two `BulkResponse`s with `ingest_took` set to
`NO_INGEST_TOOK` we'd get an `ingest_took` of `-2`. Which doesn't make
any sense. This fixes it to be set to `NO_INGEST_TOOK` properly.
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jul 31, 2025
If we combined two `BulkResponse`s with `ingest_took` set to
`NO_INGEST_TOOK` we'd get an `ingest_took` of `-2`. Which doesn't make
any sense. This fixes it to be set to `NO_INGEST_TOOK` properly.
elasticsearchmachine pushed a commit that referenced this pull request Aug 1, 2025
If we combined two `BulkResponse`s with `ingest_took` set to
`NO_INGEST_TOOK` we'd get an `ingest_took` of `-2`. Which doesn't make
any sense. This fixes it to be set to `NO_INGEST_TOOK` properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.1 v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants