Skip to content

[8.19] Upgrade MinIO (& work around bug) (#131815) #132175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

[8.19] Upgrade MinIO (& work around bug) (#131815) #132175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2053e0d
Upgrade MinIO (& work around bug) (#131815)
DaveCTurner Jul 30, 2025
3c8e946
Merge branch '8.19' into backport/8.19/pr-131815
DaveCTurner Sep 1, 2025
6ac20f7
Merge branch '8.19' into backport/8.19/pr-131815
DaveCTurner Sep 2, 2025
cf90d73
Merge branch '8.19' into backport/8.19/pr-131815
DaveCTurner Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...minio-fixture/src/main/java/org/elasticsearch/test/fixtures/minio/MinioTestContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@

public final class MinioTestContainer extends DockerEnvironmentAwareTestContainer {

// NB releases earlier than 2025-05-24 are buggy, see https://github.com/minio/minio/issues/21189, and #127166 for a workaround
// However the 2025-05-24 release is also buggy, see https://github.com/minio/minio/issues/21377, and this has no workaround
public static final String DOCKER_BASE_IMAGE = "minio/minio:RELEASE.2025-06-13T11-33-47Z";
// NB releases earlier than 2025-05-24 are buggy, see https://github.com/minio/minio/issues/21189, and #127166 for a workaround.
// However the 2025-05-24 release is also buggy, see https://github.com/minio/minio/issues/21377, and this has no workaround.
// Also https://github.com/minio/minio/issues/21456 seems to affect releases newer than 2025-05-24, see #131815 for workaround.
public static final String DOCKER_BASE_IMAGE = "minio/minio:RELEASE.2025-07-23T15-54-02Z";

private static final int servicePort = 9000;
private final boolean enabled;
Expand Down
5 changes: 5 additions & 0 deletions ...g/elasticsearch/repositories/blobstore/testkit/analyze/MinioRepositoryAnalysisRestIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ public class MinioRepositoryAnalysisRestIT extends AbstractRepositoryAnalysisRes
.keystore("s3.client.repository_test_kit.secret_key", "s3_test_secret_key")
.setting("s3.client.repository_test_kit.endpoint", minioFixture::getAddress)
.setting("xpack.security.enabled", "false")
// Skip listing of pre-existing uploads during a CAS because MinIO sometimes leaks them; also reduce the delay before proceeding
// TODO do not set these if running a MinIO version in which https://github.com/minio/minio/issues/21189
// and https://github.com/minio/minio/issues/21456 are both fixed
.setting("repository_s3.compare_and_exchange.time_to_live", "-1")
.setting("repository_s3.compare_and_exchange.anti_contention_delay", "100ms")
.setting("xpack.ml.enabled", "false")
.build();

Expand Down