failure store backport #132769
failure store backport #132769
Conversation
… into 9.1-docs-backports
… into 9.1-docs-backports
shainaraskas
added
>docs
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
|
@shainaraskas thanks so much for putting in the leg work to get this backported. I'll take a look at the tests and see if I can get them to green. |
|
Pinging @elastic/core-docs (Team:Docs) |
|
I wanted to circle back to this. These docs really weren't written with docs testing in mind. Each case requires extensive setup and teardown, and they're all quite different from each other such that it can't be the same setup/teardown logic for each test. I have some tests running after quite a bit of effort, but there's still so much to fix up here before it can execute correctly. Would it be reasonable to mute the remaining failure store tests in the 8.19 branch? We would need to revisit them when testing is reintroduced in the new docs system, but I imagine that there will be plenty of other things that will also need fixing by then. |
|
@jbaiera that would be ok with me if it's ok with you and your team. |
|
I've fixed a few tests and muted the rest of them with 4587b74 |
Added missing docs for the following features or settings:
verified to be present in 8.19 code
docs were backported as is with only edits to make them compatible with asciidoc syntax.
this is currently not passing rest tests due to cleanup/teardown requirements and the pickiness of tests.
@jbaiera hoping I can get your help with cleaning these tests up - it's unclear to me how many of the snippets SHOULD be failing due to this being a failure resolution tool. I spent a couple of hours on it but was worried I was changing things that altered the meaning of the snippets.