-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Add metrics OTLP endpoint skeleton #133296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
felixbarny
merged 14 commits into
elastic:main
from
felixbarny:otlp-tsdb-empty-endpoint
Aug 27, 2025
Merged
Add metrics OTLP endpoint skeleton #133296
felixbarny
merged 14 commits into
elastic:main
from
felixbarny:otlp-tsdb-empty-endpoint
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Protobuf will be added in a separate PR to keep the scope more contained
# Conflicts: # x-pack/plugin/otel-data/build.gradle
martijnvg
reviewed
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few comments.
...l-data/src/internalClusterTest/java/org/elasticsearch/action/otlp/OTLPMetricsIndexingIT.java
Outdated
Show resolved
Hide resolved
...l-data/src/internalClusterTest/java/org/elasticsearch/action/otlp/OTLPMetricsIndexingIT.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/ESSingleNodeTestCase.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Aug 27, 2025
...l-data/src/internalClusterTest/java/org/elasticsearch/action/otlp/OTLPMetricsIndexingIT.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Aug 27, 2025
...l-data/src/internalClusterTest/java/org/elasticsearch/action/otlp/OTLPMetricsIndexingIT.java
Outdated
Show resolved
Hide resolved
kkrik-es
approved these changes
Aug 27, 2025
martijnvg
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
external-contributor
Pull request authored by a developer outside the Elasticsearch team
>non-issue
:StorageEngine/TSDB
You know, for Metrics
Team:StorageEngine
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an empty skeleton of the OTLP endpoint behind a feature flag.
Part of #133057.