-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Add documentation about script rescorer #133359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about script rescorer #133359
Conversation
PR elastic#74274 introduced a new rescorer based on script. This adds a documentation for this rescorer.
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Hi @mayya-sharipova, because you moved stuff into a new page you'll need to add a redirect in https://github.com/elastic/elasticsearch/blob/main/docs/redirects.yml to keep existing links working Also, please use applies_to's to make it clear which versions the new functionality is relevant to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pinging @elastic/core-docs (Team:Docs) |
827a5d0
to
6f1535a
Compare
@leemthompo Thanks for the feedback. I've addressed it in 6f1535a. I am unsure about |
- https://www.elastic.co/guide/en/elasticsearch/reference/current/rescore-search-results.html | ||
applies_to: | ||
stack: all | ||
serverless: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leemthompo Does applies_to need to use both stack
and serverless
? Or providingstack
is sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayya-sharipova the page level should mention both 👍
q: should the stack be stack: GA 9.2.0
or does it not make sense to mention a specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole page is applied to all versions. Only the section Script rescorer
is applicable to 9.2.0 which I adjusted accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect thx
We should also update our spec for the auto-generated API docs: https://github.com/elastic/elasticsearch-specification |
Co-authored-by: Liam Thompson <[email protected]>
This reverts commit 646b8cd.
@leemthompo I've tried several times to do redirect, but none passes CI. |
@mayya-sharipova yikes this is a bit gnarly alright— no worries I'll take a look tomorrow |
@mayya-sharipova I got the redirect errors to go away in 376f8d2, but there were still some internal links breaking within this doc set so b33aeff just find/replaced the stragglers |
@leemthompo Thanks so much for your help, really appreciate it. |
No prob, thanks for your patience @mayya-sharipova luckily you probably won't have to use that redirect mechanism very often 😄 |
PR #74274 introduced a new rescorer based on script.
This adds a documentation for this rescorer.