Skip to content

Conversation

mayya-sharipova
Copy link
Contributor

PR #74274 introduced a new rescorer based on script.
This adds a documentation for this rescorer.

PR elastic#74274 introduced a new rescorer based on script.
This adds a documentation for this rescorer.
@mayya-sharipova mayya-sharipova added >docs General docs changes :Search Relevance/Ranking Scoring, rescoring, rank evaluation. v9.2.0 labels Aug 21, 2025
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Aug 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@leemthompo
Copy link
Contributor

leemthompo commented Aug 22, 2025

Hi @mayya-sharipova, because you moved stuff into a new page you'll need to add a redirect in https://github.com/elastic/elasticsearch/blob/main/docs/redirects.yml to keep existing links working

Also, please use applies_to's to make it clear which versions the new functionality is relevant to.

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

@mayya-sharipova mayya-sharipova force-pushed the srcipt_rescore_documentation branch from 827a5d0 to 6f1535a Compare August 22, 2025 17:12
@mayya-sharipova
Copy link
Contributor Author

@leemthompo Thanks for the feedback. I've addressed it in 6f1535a. I am unsure about redirect syntax, would appreciate your feedback on this change.

- https://www.elastic.co/guide/en/elasticsearch/reference/current/rescore-search-results.html
applies_to:
stack: all
serverless: all
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leemthompo Does applies_to need to use both stack and serverless? Or providingstack is sufficient?

Copy link
Contributor

@leemthompo leemthompo Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayya-sharipova the page level should mention both 👍

q: should the stack be stack: GA 9.2.0 or does it not make sense to mention a specific version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole page is applied to all versions. Only the section Script rescorer is applicable to 9.2.0 which I adjusted accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect thx

@benwtrent
Copy link
Member

We should also update our spec for the auto-generated API docs: https://github.com/elastic/elasticsearch-specification

@mayya-sharipova
Copy link
Contributor Author

@leemthompo I've tried several times to do redirect, but none passes CI.
Would appreciate your help on this. Feel free to push to this branch.

@leemthompo
Copy link
Contributor

@mayya-sharipova yikes this is a bit gnarly alright— no worries I'll take a look tomorrow

@leemthompo
Copy link
Contributor

leemthompo commented Aug 26, 2025

@mayya-sharipova I got the redirect errors to go away in 376f8d2, but there were still some internal links breaking within this doc set so b33aeff just find/replaced the stragglers

@mayya-sharipova
Copy link
Contributor Author

@leemthompo Thanks so much for your help, really appreciate it.

@mayya-sharipova mayya-sharipova merged commit d8257b4 into elastic:main Aug 26, 2025
9 of 10 checks passed
@leemthompo
Copy link
Contributor

No prob, thanks for your patience @mayya-sharipova luckily you probably won't have to use that redirect mechanism very often 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants