Skip to content

[8.19] Check entitlements for URLClassLoader.newInstance (#132725) #133911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

[8.19] Check entitlements for URLClassLoader.newInstance (#132725) #133911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de26ea5
Check entitlements for URLClassLoader.newInstance (#132725)
mosche Sep 1, 2025
8d9653b
Merge branch '8.19' into backport/8.19/pr-132725
mosche Sep 2, 2025
d6e4b0f
Merge branch '8.19' into backport/8.19/pr-132725
mosche Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...tlement/bridge/src/main/java/org/elasticsearch/entitlement/bridge/EntitlementChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ public interface EntitlementChecker {

void check$java_net_URLClassLoader$(Class<?> callerClass, String name, URL[] urls, ClassLoader parent, URLStreamHandlerFactory factory);

void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls, ClassLoader parent);

void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls);

void check$java_security_SecureClassLoader$(Class<?> callerClass);

void check$java_security_SecureClassLoader$(Class<?> callerClass, ClassLoader parent);
Expand Down
14 changes: 14 additions & 0 deletions ...titlement-test-plugin/src/main/java/org/elasticsearch/entitlement/qa/test/JvmActions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,20 @@ static void createClassLoader() throws IOException {
}
}

@EntitlementTest(expectedAccess = PLUGINS)
static void createClassLoaderNewInstance1() throws IOException {
try (var classLoader = URLClassLoader.newInstance(new URL[0])) {
// intentionally empty, just let the loader close
}
}

@EntitlementTest(expectedAccess = PLUGINS)
static void createClassLoaderNewInstance2() throws IOException {
try (var classLoader = URLClassLoader.newInstance(new URL[0], RestEntitlementsCheckAction.class.getClassLoader())) {
// intentionally empty, just let the loader close
}
}

@EntitlementTest(expectedAccess = ALWAYS_DENIED)
static void createLogManager() {
new java.util.logging.LogManager() {
Expand Down
10 changes: 10 additions & 0 deletions ...in/java/org/elasticsearch/entitlement/runtime/policy/ElasticsearchEntitlementChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,16 @@ public ElasticsearchEntitlementChecker(PolicyChecker policyChecker) {
policyChecker.checkCreateClassLoader(callerClass);
}

@Override
public void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls) {
policyChecker.checkCreateClassLoader(callerClass);
}

@Override
public void check$java_net_URLClassLoader$$newInstance(Class<?> callerClass, URL[] urls, ClassLoader parent) {
policyChecker.checkCreateClassLoader(callerClass);
}

@Override
public void check$java_security_SecureClassLoader$(Class<?> callerClass) {
policyChecker.checkCreateClassLoader(callerClass);
Expand Down