Skip to content

Conversation

DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Sep 4, 2025

These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach green health. This commit ensures there are
enough nodes to allocate all the shards.

Closes #133455
Closes #134124
Closes #134123

These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes elastic#133455
Closes elastic#134124
@DaveCTurner DaveCTurner requested a review from ywangd September 4, 2025 11:52
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v9.2.0 v9.1.4 v9.0.7 v8.19.4 labels Sep 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Sep 4, 2025
@DaveCTurner DaveCTurner added v8.18.7 and removed Team:Distributed Coordination Meta label for Distributed Coordination team labels Sep 4, 2025
Copy link
Contributor

@joshua-adams-1 joshua-adams-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaveCTurner DaveCTurner added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Sep 4, 2025
@DaveCTurner DaveCTurner changed the title Ensure enough nodes in WriteLoadForeacasterIT Ensure enough nodes in WriteLoadForecasterIT Sep 4, 2025
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd
Copy link
Member

ywangd commented Sep 5, 2025

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit abc660f into elastic:main Sep 5, 2025
33 checks passed
@DaveCTurner DaveCTurner deleted the 2025/09/04/WriteLoadForecasterIT-ensure-cluster-size branch September 5, 2025 08:46
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.1 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts
8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 134132

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes elastic#133455
Closes elastic#134124
Closes elastic#134123
Backport of elastic#134132 to `9.1`
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes elastic#133455
Closes elastic#134124
Closes elastic#134123
Backport of elastic#134132 and elastic#134099 to `9.0`
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes elastic#133455
Closes elastic#134124
Closes elastic#134123
Backport of elastic#134132 and elastic#134099 to `8.19`
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes elastic#133455
Closes elastic#134124
Closes elastic#134123
Backport of elastic#134132 and elastic#134099 to `8.18`
elasticsearchmachine pushed a commit that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes #133455
Closes #134124
Closes #134123
Backport of #134132 and #134099 to `8.19`
elasticsearchmachine pushed a commit that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes #133455
Closes #134124
Closes #134123
Backport of #134132 and #134099 to `8.18`
elasticsearchmachine pushed a commit that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes #133455
Closes #134124
Closes #134123
Backport of #134132 and #134099 to `9.0`
elasticsearchmachine pushed a commit that referenced this pull request Sep 5, 2025
These tests would sometimes create 1-replica indices in a 1-node cluster
which will never reach `green` health. This commit ensures there are
enough nodes to allocate all the shards.

Closes #133455
Closes #134124
Closes #134123
Backport of #134132 to `9.1`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.18.7 v8.19.4 v9.0.7 v9.1.4 v9.2.0
Projects
None yet
5 participants