Fix ML calendar event update scalability issues #136886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue - Use RefCountingListener for parallel calendar/filter updates - Add comprehensive logging throughout the system - Create CalendarScalabilityIT integration tests - Add helper methods to base test class Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing.
|
Hi @valeriy42, I've created a changelog YAML for you. |
…g to API calls and processing job updates asynchronously in the background.
…thub.com/valeriy42/elasticsearch into bugfix/limited-update-notification-queue
…e handling in JobManager to include skipped updates. Update logging to reflect skipped updates during background calendar processing.
…hods and updating job creation visibility. Enhance ScheduledEventsIT to verify asynchronous calendar updates and add a plugin for tracking UpdateProcessAction calls.
…the updated logging package. This change improves consistency and aligns with recent codebase updates.
|
Pinging @elastic/ml-core (Team:ML) |
…thub.com/valeriy42/elasticsearch into bugfix/limited-update-notification-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing.
Problem:
UpdateJobProcessNotifierhas a 1000-item queue and processes updates sequentially. It usesoffer()on the queue, which silently drops updates when the queue is full.However, calendar/filter updates don't need ordering guarantees. Hence,
JobManager.submitJobEventUpdate()can bypass the queue and avoid the bottleneck of the queue size.Another problem is the "fire-and-forget" pattern:
submitJobEventUpdate()returns immediately without waiting for the update to complete. I introduceRefCountingListenerto track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout.Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics.
Fixes #129777