Pre-compile mapping_includes filter in LogsdbIndexModeSettingsProvider #136899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>non-issue
Team:StorageEngine
:StorageEngine/Logs
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
jordan-powers
added
auto-backport
|
For what it's worth, here's a flamegraph from ingest simulate, starting with the call to TransportSimulateIndexTemplateAction.resolveTemplate. The right 40% or so is LogsdbIndexModeSettingsProvider.provideAdditionalSettings(): |
|
And here is the flamegraph for the same test on your branch (better as expected): |
martijnvg
approved these changes
Oct 22, 2025
💚 Backport successful
|
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Oct 22, 2025
elastic#136899) Some recent profiling showed that compiling the mapping_includes filter in LogsdbIndexModeSettingsProvider#getMappingHints was very expensive. This PR moves that work so that it only happens once, when the class is constructed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent profiling showed that compiling the mapping_includes filter in LogsdbIndexModeSettingsProvider#getMappingHints was very expensive. This PR moves that work so that it only happens once, when the class is constructed.