Adjust test fixture lifecycle ordering in apm integration tests #136926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>test
elasticsearchmachine
added
v8.19.7
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Oct 22, 2025
mark-vieira
added
auto-backport
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 22, 2025
This was referenced Oct 22, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 22, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address test failures in #136913 which are believed to be a side effect of test fixture ordering. As it is, we are stopping ES and then the mock APM server. It's not clear how the APM client handles this but it seems like it is either truncating requests, or terminating connections before the server can send a response. This makes the JDK HttpServer cranky. To avoid this or other special resilient handling, we just tweak the fixture ordering such that we stop the APM server before ES. This should avoid the scenario of partial request bodies or closed connections.