[Experimental][Theme tokens] Extend vis colors and default palette - #10004
Draft
biamalveiro wants to merge 3 commits into
Draft
[Experimental][Theme tokens] Extend vis colors and default palette#10004biamalveiro wants to merge 3 commits into
biamalveiro wants to merge 3 commits into
Conversation
💚 Build Succeeded
|
📷 28 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuiavatar (2 differences)
euicolorpalettepicker (14 differences)
euicolorpicker (6 differences)
euiheader (6 differences)
|
10 tasks
💔 Build Failed
Failed CI StepsHistory
|
📷 28 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuiavatar (2 differences)
euicolorpalettepicker (14 differences)
euicolorpicker (6 differences)
euiheader (6 differences)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.














































































Summary
WIP / Experimental. (Parallel to elastic/kibana#289631)
This is a first analysis, related to elastic/kibana#271428.
Lens chart behavior will be validated in parallel.
Adds two assistance/purple stops to the Borealis vis palette (
euiColorVis10/euiColorVis11) and includes them ineuiPaletteColorBlind()so the default categorical palette is 12 colors.To follow the process used during the development of the original palette, we should also check contrast between colors (and light/dark backgrounds), to ensure new colors do not pose risks. To support this analysis, added a storybook story to help in this process. This recreates the elements made by @gvnmagni when developing the original palette, so we can properly test this: a color grid that makes it easier to visualise the selected hues+shades in a palette + a contrast matrix, that calculates APCA contrast checks. This dynamic version allows setting an adaptive threshold depending on size of non-semantic elements, as per these guidelines.
This story and respective components are dev helpers for this issue and can be removed before merging, so that change is limited to vis colors, if we decide to proceed.
Analysis