Skip to content

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Jul 25, 2025

Summary

I'm adding a documentation for:

  • euiFontSizeFromScale
  • euiLineHeightFromBaseline
  • euiTextShift

Why are we making this change?

There was an internal request from a Kibana developer. They were migrating Sass and wanted to replace lineHeightFromBaseline with euiLineHeightFromBaseline.

I noticed that there is no documentation around those utilities we export and they confirmed it would help them if there was documentation.

Screenshots

Screenshot 2025-07-25 at 14 37 05 Screenshot 2025-07-25 at 14 37 11

Impact to users

🟢 Just a docs change. No impact on users.

QA

  • Verify that all typography utilities are correctly documented in the new section

@weronikaolejniczak weronikaolejniczak self-assigned this Jul 25, 2025
@weronikaolejniczak weronikaolejniczak added support-duty-flywheel Label for PRs, see eui-private #310 skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Jul 25, 2025
@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review July 25, 2025 12:40
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner July 25, 2025 12:40
@tkajtoch tkajtoch self-requested a review August 1, 2025 22:45
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added docs look solid! I'm going to approve this right now despite my nit pick. Feel free to update the import path and enable auto merge! 🚢

@weronikaolejniczak weronikaolejniczak enabled auto-merge (squash) August 5, 2025 08:28
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @weronikaolejniczak

@weronikaolejniczak weronikaolejniczak merged commit fb461ac into elastic:main Aug 5, 2025
5 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @weronikaolejniczak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) support-duty-flywheel Label for PRs, see eui-private #310

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants