-
Notifications
You must be signed in to change notification settings - Fork 860
[DRAFT] Snappier animation settings for flyouts #8919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f51816 to
403b022
Compare
|
Something that I am uncertain about is how this looks for 'large' flyouts. Before opening and merging this, let's test the settings in the parent+child setup once @tkajtoch gets to adding animations there. It could be better or worse: better because there are multiple flyouts moving and seeing the full animation from 0 to 100 might be jarring; worse if this animation seems to begin too late. I think it may be better but need to see it in the flesh before deciding and would love input from others, again, at that point. |
|
I LOVE this new animation! I tested it with |
|
Quick update:
|
|
@ryankeairns if it's not ready to be merged / approved / tested for final results, could we mark it as a draft PR? |
|
Ah, neat! I had accidentally clicked 'Ready for review' last week when I meant to click 'Update branch' |
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
|
@tkajtoch closing this as I believe you have worked through (or are close to working through) the flyout changes. |
|
I'll integrate your changes into my animations PR! |
Summary
There is some adjacent work going on to bring animations to
EuiFlyoutChild, so I wanted to take a parallel swipe at updating the animation settings (see #8896).This PR is a test to make the animation feel a little more snappy: faster in the front and middle, then ease out.
Versus what we have today which is, in comparison, a bit more slow in the beginning and end.
Changes
cubic-bezier(0.32, 0.72, 0, 1)feels more alive/snappy.cubic-bezier(.694, .0482, .335, 1)is more smooth/naturalTweaked the keyframe from
75%to85%. This change makes the flyout animation feel less abrupt, as the flyout spends more time in motion rather than too quickly snapping to its final position.Testing notes
Preview and compare old versus new:
Other impacts:
animation.resistanceis used in other components, but it is most noticeable inEuiFlyout.To my eye, the keyframe and bezier tweaks make it ever so snappier (e.g. the title in the header leaves less of a visual 'trace')
TODO