-
Notifications
You must be signed in to change notification settings - Fork 861
[Flyouts] Support for "large" child flyout #8926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flyouts] Support for "large" child flyout #8926
Conversation
| min-inline-size: 90vw; | ||
| inline-size: 90vw; | ||
| max-inline-size: 90vw; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is consistent with the behavior of the existing code: for push type main flyouts, the child flyout only occupies the amount of space it should have if the main flyout width changes to match it. But, this behavior becomes more problematic for the scenario where the child flyout has size="fill". If the main flyout has type="push", then then underlying content is squeezed into the remaining space. When the screen gets smaller in that scenario and the child flyout is stacked above the main flyout, the underlying content is squeezed into 10vw of space.
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import React, { useState, ComponentProps } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely refactored this story to better take advantage of args. Now we don't need separate stories to demo different configurations of props.
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
1fb4398 to
10b6549
Compare
780899d to
67b1f48
Compare
6c9eac3 to
d811dac
Compare
|
Replaced with #8982 |
Summary
This PR adds support for
size="fill"forEuiFlyoutChild.Fill mode for for
EuiFlyoutwill come as a later PR.Why are we making this change?
Part of https://github.com/elastic/kibana-team/issues/1844
Screenshots
Main=s, Child=fill, type=overlay

Main=s, Child=fill, type=push

Impact to users
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles