Update pull_request_template.md #9018
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing new template....
Hypothetical rewrite of #8800
Summary #
This PR adds high contrast mode color values for data visualization and severity color tokens.
Changes
Accessibility check (Required if applicable) #
Each color in this palette was checked against these background colors (some hypothetical list of colors here) with a contrast ratio checker plugin for the Chrome Browser.
Changelog context (Required if changelog included)
Why are we making this change? #
We made this change because our current data visualization and severity colors did not meet 3:1 contrast ratios in light mode. This change solves that by adding high-contrast variants to the data visualization and severity color palettes, but ONLY high-contrast mode is enabled.
Related EUI issues or initiatives:
Related issues or initiatives from other Elastic products (Kibana, Cloud, etc.):
API Changes #
Functional changes #
This PR has no functional changes that users should be aware of
Visual changes #
Since the color tokens have been changed, that means that existing usages of the colors tokens list above will visually change for users when light mode and high-contrast mode are enabled.
Doc updates (How to contribute docs) #
{Provide a link}
{Provide a link}
EUI library Figma updates #
{Provide a link}
{Provide a link}
(Figma issues can be filed : here (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)
Screenshots #
Reproduction instructions #
Navigate to the Data Vis colors or Severity colors pages and use the Light / Dark mode and High-Contrast mode toggles in the top right-hand corner of the docs site to toggle on light mode and high-contrast mode, and observe that the colors in both of these sections have changed.
Impact assessment #
breaking change
label to this issue and the migration instructions are as follows:Scope of impact in Elastic products:
euiColorVis
colors in Kibana.euiColorVis
colors in Cloud UI.Rollout / adoption #
No rollout required.
Note: While this change updates all data vis colors and severity colors in EUI to have a 3:1 ratio, it will not immediately affect Kibana, as those colors come from elastic-charts. The elastic-charts team will need to make those changes separately.
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@default
if default values are missing) and playground toggles