[fix] Keep Flyout Manager sync'd across React roots. #9075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Failed CI StepsHistory
|
💚 Build Succeeded
|
tkajtoch
reviewed
Oct 6, 2025
| "unified": "^9.2.2", | ||
| "unist-util-visit": "^2.0.3", | ||
| "url-parse": "^1.5.10", | ||
| "use-sync-external-store": "^1.6.0", |
There was a problem hiding this comment.
Note to other reviewers: useSyncExternalStore is shipped with React starting from version 18.0. We need this shim for React 17 support
tsullivan
reviewed
Oct 6, 2025
| */ | ||
|
|
||
| import React, { createContext, useContext } from 'react'; | ||
| import { useFlyoutManagerReducer } from './hooks'; |
There was a problem hiding this comment.
useFlyoutManagerReducer is now only used in tests. Do we need to keep it for any reason?
tsullivan
reviewed
Oct 6, 2025
| state, | ||
| ...rest, | ||
| goToFlyout, | ||
| getHistoryItems: () => { |
There was a problem hiding this comment.
Since this is selector logic, maybe a better architecture would be to move getHistoryItems to the store. Doing so would make it so that we don't need to destructure goToFlyout from the store on line 28.
tsullivan
reviewed
Oct 6, 2025
|
Thanks @tsullivan I'll make the adjustments and open for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. Adds a module-level singleton instance of the store and enhances the provider with
useSyncExternalStore, (adds a Meta-maintained shim to support React 17).I wrote this pretty quickly, and leveraged Gemini in some cases. Should be reviewed and revised with this in mind.