[Enhancement] Update categories for packages #14571
Conversation
There was a problem hiding this comment.
The addition of the network_security category in packages/beaconing should work; cc @sodhikirti07
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Without elastic/package-spec providing any description of the category meanings, there is some subjectivity to the labeling. I have brought my own assumptions to this review.
Overall looks good, it probably would be good for PMs that know these products to also have a look.
andrewkroh
added
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
|
Pinging @elastic/sec-applied-ml (Team:Security-Applied ML) |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
|
Added @daniela-elastic to help review the o11y package changes. |
There was a problem hiding this comment.
What about universal_profiling_collector and universal_profiling_symbolizer?
There was a problem hiding this comment.
you suggest to update categories to include observability?
packages/activemq/manifest.yml
Outdated
There was a problem hiding this comment.
Could we say that ActiveMQ is part of the infrastructure stack and what is the definition of infra stack? Asking because we have an integration Kafka which one could argue is an alternative to ActiveMQ (minus the streaming part) however today Kafka integration doesn't have infra category. Perhaps we should look into conformity between the various similar family of services to make sure they are categorized in the same way.
|
@daniela-elastic I have updated code according to your comments |
💔 Build Failed
Failed CI StepsHistory
|
|
We are using categories of packages in telemetry and it seems that categories of packages are not reliable as I found a few of security packages not marked as such, for example
awsetc.I took advantage of LLM to update the list of categories according to the readme in each integration and using this list of available categories
I have verified it as much as I could but as it touches a lot of integrations it would be great to have more eyes on it.
Every new category has justification
p.s. I am new to the integrations development so it might be I’m missing some of the usages of categories and current changes might break something. If so - I am happy to update the PR
FYI @vglagoleva @andrewkroh