Skip to content

Conversation

giorgi-imerlishvili-elastic
Copy link
Contributor

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic commented Jul 17, 2025

Proposed commit message

Update package statsd_input's manifest.yml format_version to 3.4.0
Update files packages/statsd_input/fields/input.yml and packages/statsd_input/manifest.yml accordingly

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Related issues

Closes https://github.com/elastic/obs-integration-team/issues/387

Screenshots

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic added the enhancement New feature or request label Jul 17, 2025
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic marked this pull request as ready for review July 17, 2025 12:45
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic requested a review from a team as a code owner July 17, 2025 12:45
Copy link
Contributor

@mykola-elastic mykola-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mykola-elastic
Copy link
Contributor

@ishleenk17 system tests pass and it was tested using local stack by @giorgi-imerlishvili-elastic

version: "0.6.0"
description: StatsD Input Package
type: input
source:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it errroing out that we had to add this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked other packages with version upper than 3.0 and used those packages as example
But I think without that property it should work either, because it's not defined as required property in spec: https://github.com/elastic/package-spec/blob/v3.4.0/spec/input/manifest.spec.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishleenk17 shall source.license be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not a mandate, we can remove it

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jul 17, 2025
Copy link
Contributor

@stefans-elastic stefans-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishleenk17
Copy link
Member

/test

@ishleenk17
Copy link
Member

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @giorgi-imerlishvili-elastic

Copy link

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic merged commit 30d8fc9 into elastic:main Jul 24, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package statsd_input - 0.6.0 containing this change is available at https://epr.elastic.co/package/statsd_input/0.6.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:statsd_input StatsD Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants