Skip to content

Conversation

@jrmolin
Copy link
Contributor

@jrmolin jrmolin commented Oct 30, 2025

Proposed commit message

[citrix_adc] Update Documentation via LLM

  • ask an LLM to use the existing documentation to fill out the must-be-correct information
  • ask an LLM to use the existing documentation, as well as web queries to update the README.md to the new format / template

Checklist

  • new documentation is at least not inferior to previous documentation

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package citrix_adc 👍(1) 💚(4) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
interface 5128.21 3759.4 -1368.81 (-26.69%) 💔

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:citrix_adc Citrix ADC labels Oct 31, 2025
@jrmolin jrmolin marked this pull request as ready for review October 31, 2025 18:59
@jrmolin jrmolin requested review from a team as code owners October 31, 2025 18:59
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 8.12.0 listed several times as the minimum stack version, but the manifest defines 8.13.0 as the minimum version. Where is 8.12.0 coming from?

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Oct 31, 2025
@jrmolin
Copy link
Contributor Author

jrmolin commented Nov 4, 2025

I used Cursor to generate the ground-truth-file, and that chose 8.12.0, which I missed. Thanks for catching that, @taylor-swanson !

@elasticmachine
Copy link

💚 Build Succeeded

History


After configuration, open the Citrix ADC integration’s **Assets** tab to view the available dashboards. They should populate with data for the configured datasets. You can also verify metrics and logs in **Discover** under the `logs-*` data view.

## Troubleshooting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrmolin I feel the troubleshoot section is actually worst than the original one.
what happened to this section? Is it not valuable in documentation?


Dummy values
It is possible that for some fields, Citrix ADC sets dummy values. For example, a field cpuusagepcnt is represented by citrix_adc.system.cpu.utilization.pct. cpuusagepcnt is set to 4294967295 for some netscaler/netscaler-adc-metrics-exporter#44. If you also encounter it for some fields, reach out to the Citrix ADC support team.

Type conflicts
If host.ip is shown conflicted under logs-* data view, this issue can be solved by reindexing the Interface, LBVserver, Service, System, and VPN data stream's indices.

Copy link
Contributor

@qcorporation qcorporation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation started out pretty good to begin with. I think that we have to be careful not to lose any information that might be important in the original documentation when we generate the new LLM one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:citrix_adc Citrix ADC Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants