Reliably run acceptance tests in Kibana client buildkite pipeline #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobio
force-pushed
the
kibana-client-buildkite
branch
2 times, most recently
from
325af99 to
f82109d
Compare
tobio
force-pushed
the
kibana-client-buildkite
branch
from
f82109d to
972959c
Compare
nick-benoit
previously approved these changes
Oct 20, 2025
|
|
||
| func TestSyntheticPrivateLocationResource(t *testing.T) { | ||
| resourceId := "elasticstack_kibana_synthetics_private_location.test" | ||
| randomSuffix := sdkacctest.RandStringFromCharSet(4, sdkacctest.CharSetAlphaNum) |
There was a problem hiding this comment.
I'm not quite sure I follow why we need the random suffix for this resource but not for others. Should we add a comment to explain if there is something special about them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1309