Skip to content

fix: use siso for chrome target instead of reclient #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use siso for chrome target instead of reclient #768

wants to merge 2 commits into from
+3 −3

Conversation

@mitchchn
Copy link

@mitchchn mitchchn commented Oct 27, 2025

No description provided.

@mitchchn mitchchn requested review from a team and ckerr as code owners October 27, 2025 16:57
@dsanders11 dsanders11 changed the title Use siso for chrome target instead of reclient fix: use siso for chrome target instead of reclient Oct 27, 2025
dsanders11
dsanders11 approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the title to pass the semantic PR title check.

I think we probably want to just rip out the reclient stuff all together soon, but since that's going to be a large PR, I'm happy to accept this small focused change for now. 👍

jkleinsc
jkleinsc requested changes Oct 28, 2025
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That I know of siso still uses the reclient configs, so we should still leave this code in.

jkleinsc
jkleinsc requested changes Oct 28, 2025
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need the reclient_cfgs, they are referenced in siso configs: https://source.chromium.org/chromium/chromium/src/+/main:build/config/siso/clang_windows.star;l=33?q=build%2Fconfig%2Fsiso%2Fclang_windows.star&ss=chromium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc requested changes

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@ckerr ckerr Awaiting requested review from ckerr ckerr is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mitchchn @jkleinsc @codebytere @dsanders11