Skip to content

Conversation

@dsanders11
Copy link
Member

This PR:

  • Switches the bespoke setup of DigiCert's signing tools to using the digicert/ssm-code-signing code action
  • Properly exports the SM_CLIENT_CERT_FILE environment variable and makes use of it
  • Liberally sets environment variables for the Windows steps
  • Fixes the Linux build step having a wrong if field
  • Reverts build: use @electron/windows-sign #1785, I still couldn't get that working 🤷

Lessons learned:

  • In GHA, powershell and pwsh are different versions of PowerShell, not just aliases for each other
  • If some of the environment variables aren't set, things fail with entirely unhelpful error messages

@dsanders11 dsanders11 requested review from a team and codebytere as code owners October 29, 2025 06:20
@coveralls
Copy link

Coverage Status

coverage: 80.223% (+0.01%) from 80.211%
when pulling d67e695 on ci/fix-windows-signing-release
into c23b792 on main.

@dsanders11 dsanders11 merged commit 02e380f into main Oct 29, 2025
11 checks passed
@dsanders11 dsanders11 deleted the ci/fix-windows-signing-release branch October 29, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants