Skip to content

Conversation

davidegirardi
Copy link
Contributor

Underline the awesome joke someone just said in the call with a twist on a classic punchline drum fill.

@davidegirardi davidegirardi requested a review from a team as a code owner April 17, 2025 06:55
@davidegirardi davidegirardi requested a review from robintown April 17, 2025 06:55
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fkwp
❌ Davide Girardi


Davide Girardi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as product is happy with this (@fkwp)

- `end_call`
- `reactions/rock`
- `reactions/wave`
- `reactions/baduntss`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you record this on your own drum kit? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I played on a MIDI controller to trigger samples.

@robintown robintown added X-Blocked Cannot be merged due to external dependencies and removed X-Blocked Cannot be merged due to external dependencies labels May 28, 2025
@spaetz
Copy link

spaetz commented Jun 20, 2025

@davidegirardi sorry for pinging you, I am just an outsider :-), but this seems to be stuck waiting for you to sign the CLA.

@davidegirardi
Copy link
Contributor Author

@spaetz I'm an Element employee, no CLA needed. I also put the file as "created by Element" in the license file.

@davidegirardi
Copy link
Contributor Author

I merged the livekit branch onto this and re-run CI, which seems happy https://github.com/element-hq/element-call/actions/runs/17757667742. The first time it failed because of repo.yarnpkg.com return 500s.

@fkwp fkwp merged commit 5811794 into livekit Sep 16, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature Release note category. A PR that introduces a new user facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants