-
Notifications
You must be signed in to change notification settings - Fork 125
Add drum/joke reaction #3217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drum/joke reaction #3217
Conversation
Davide Girardi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
e6ba067
to
09b1076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as long as product is happy with this (@fkwp)
- `end_call` | ||
- `reactions/rock` | ||
- `reactions/wave` | ||
- `reactions/baduntss` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you record this on your own drum kit? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. I played on a MIDI controller to trigger samples.
@davidegirardi sorry for pinging you, I am just an outsider :-), but this seems to be stuck waiting for you to sign the CLA. |
@spaetz I'm an Element employee, no CLA needed. I also put the file as "created by Element" in the license file. |
I merged the livekit branch onto this and re-run CI, which seems happy https://github.com/element-hq/element-call/actions/runs/17757667742. The first time it failed because of repo.yarnpkg.com return 500s. |
Underline the awesome joke someone just said in the call with a twist on a classic punchline drum fill.