Add alert to encrypted rooms with visible history (Android).

[kaylendog]

Content

• Adds a dismissable alert that is displayed whenever the user opens a room with history_visibility != joined. When cleared, this is recorded in the app's data store.
• When opening a room with history_visibility = joined, this flag is cleared.`

Motivation and context

This is part of ongoing work to implement production-ready encrypted room history.

Issue: element-hq/element-meta#2875

Screenshots / GIFs

Tests

1. Create a new private (encrypted) room. Since Element X defaults to invited history visibility, the new banner should be visible immediately upon opening the room.
2. Dismiss the banner, then re-open the room. It should not be visible.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• Your branch should be based on origin/develop, at least when it was created.
• The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[kaylendog]

I'm not sure if this is the correct naming scheme to use?

[jmartinesp]

Sorry for the long delay in reviewing this. I added a question, because I'm not sure I understand the logic behind one of the changes.

[jmartinesp]

Could you record new screenshots following the instructions here? I've tried doing it myself but I think it'll fail since the action won't have permissions to add code to your fork. Thanks!

[bmarty]

To properly support multi-account, I believe that we would need to have a store per account. You can inject the sessionId in the constructor and use it to create a dedicated store.
Also when the session is deleted (log out), I guess we should do some cleanup? We can handle this part maybe since the code is not ideal so far regarding this.

[bmarty]

an other option is to have a single store, but include the sessionId in the preference keys.