Skip to content

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 26, 2025

This only allows them to be shown, accepting the invites isn't going to show the SpaceScreen yet, it'll simply be treated as a room and so it will show the space's timeline. It also doesn't update the cell design yet either.

@pixlwave pixlwave requested a review from a team as a code owner September 26, 2025 10:57
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 26, 2025 10:57
@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Sep 26, 2025
Copy link

github-actions bot commented Sep 26, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against cee5687

Copy link

codecov bot commented Sep 26, 2025

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
1133 10 1123 0
View the top 3 failed test(s) by shortest run time
PreviewTests::testLoginScreen()
Stack Traces | 10.1s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
PreviewTests::testSecureBackupLogoutConfirmationScreen()
Stack Traces | 10.7s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
DeferredFulfillmentTests::testObservableWithSynchronousUpdate()
Stack Traces | 12.5s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
View the full list of 7 ❄️ flaky test(s)
NotificationSettingsEditScreenViewModelTests::testSetModeFailure()

Flake rate in main: 42.67% (Passed 43 times, Failed 32 times)

Stack Traces | 10.2s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
NotificationSettingsScreenViewModelTests::testFixInconsistentSettings()

Flake rate in main: 42.67% (Passed 43 times, Failed 32 times)

Stack Traces | 10.1s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
PreviewTests::testSessionVerification()

Flake rate in main: 43.24% (Passed 84 times, Failed 64 times)

Stack Traces | 11.4s run time
failed - Snapshot "Accepting Verification Request-iPhone 16-en-GB" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/sessionVerification.Accepting-Verification-Request-iPhone-16-en-GB.png"
@+
"file:.../tmp/PreviewTests/sessionVerification.Accepting-Verification-Request-iPhone-16-en-GB.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9802246 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:106)
PreviewTests::testSettingsScreen()

Flake rate in main: 43.24% (Passed 84 times, Failed 64 times)

Stack Traces | 10.2s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
RoomDetailsScreenViewModelTests::testIgnoreFailure()

Flake rate in main: 42.67% (Passed 43 times, Failed 32 times)

Stack Traces | 10s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
RoomDetailsScreenViewModelTests::testIgnoreSuccess()

Flake rate in main: 42.67% (Passed 43 times, Failed 32 times)

Stack Traces | 10s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)
RoomDetailsScreenViewModelTests::testUnignoreFailure()

Flake rate in main: 42.67% (Passed 43 times, Failed 32 times)

Stack Traces | 10s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

# Conflicts:
#	PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPad-en-GB-0.png
#	PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPad-pseudo-0.png
#	PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPhone-16-en-GB-0.png
#	PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPhone-16-pseudo-0.png
Copy link

@pixlwave
Copy link
Member Author

Those snapshot failures are fixed in #4553.

@pixlwave pixlwave merged commit c5fccdc into develop Sep 29, 2025
14 of 15 checks passed
@pixlwave pixlwave deleted the doug/space-invites branch September 29, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants