-
Notifications
You must be signed in to change notification settings - Fork 194
Show space invites in the room list. #4545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger Swift against cee5687 |
❌ 10 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 7 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
ElementX/Sources/Screens/HomeScreen/View/HomeScreenInviteCell.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPad-en-GB-0.png # PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPad-pseudo-0.png # PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPhone-16-en-GB-0.png # PreviewTests/Sources/__Snapshots__/PreviewTests/homeScreenInviteCell.iPhone-16-pseudo-0.png
a1f3b32
to
133e992
Compare
|
Those snapshot failures are fixed in #4553. |
This only allows them to be shown, accepting the invites isn't going to show the
SpaceScreen
yet, it'll simply be treated as a room and so it will show the space's timeline. It also doesn't update the cell design yet either.