Send only latest membership events down (legacy) /sync #18648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
1 task
This commit aims to fix the edge case where a user has multiple membership events for a single room in a single sync period, and ends up receiving both down /sync. This confuses the client, as they don't know which membership event is the latest - only the server does. Thus we exclude "older" membership events from /sync, where ordering is defined by events' "stream_ordering". Now clients will only get one membership event per room per sync - the latest.
anoadragon453
force-pushed
the
anoa/sync_latest_membership_events
branch
from
cd6a462 to
e5541ab
Compare
| @@ -0,0 +1 @@ | |||
| Only include latest membership events for each user/room combination in a single incremental legacy sync response. No newline at end of file | |||
There was a problem hiding this comment.
I assume this also fixes #1413 (join/leave) vs (leave/invite)
There was a problem hiding this comment.
I think it would, yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14683
This PR aims to fix the edge case where a user has multiple membership events for a single room in a single sync period, and ends up receiving both down /sync. This confuses the client, as they don't know which membership event is the latest - only the server does.
Thus we exclude "older" membership events from /sync, where ordering is defined by events' "stream_ordering". Now clients will only get one membership event per room per sync - the latest.
Associated Complement tests: matrix-org/complement#787
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.