-
Notifications
You must be signed in to change notification settings - Fork 372
Refactor background process metrics to be homeserver-scoped #18670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MadLittleMods
merged 27 commits into
develop
from
madlittlemods/18592-background-process-metrics-counter-server-name-label
Jul 23, 2025
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a92f8d6
Fill in `synapse/metrics/background_process_metrics.py`
MadLittleMods d40c244
Fill in `synapse/metrics/background_process_metrics.py` (`run_as_back…
MadLittleMods cebaa2e
Merge branch 'develop' into madlittlemods/18592-background-process-me…
MadLittleMods 03b7d9b
Merge branch 'develop' into madlittlemods/18592-background-process-me…
MadLittleMods 6c091b1
Fill in `get_retry_limiter`
MadLittleMods 72b8815
Fill in some missing `self.server_name` that are part of #18656
MadLittleMods 52301fe
Fill in `synapse/replication/tcp/protocol.py`
MadLittleMods 013f607
Fixup `BatchingQueue`
MadLittleMods 2306f63
Fixup `MultiWriterIdGenerator`
MadLittleMods 545f674
Restore `self.store` in `ApplicationServiceScheduler` (still being used)
MadLittleMods b758bf6
Add changelog
MadLittleMods 467a6cb
Fix `self.server_name` missing because super constructor didn't run yet
MadLittleMods 5538178
Convert `@wrap_as_background_process` -> `run_as_background_process` …
MadLittleMods b574a29
Convert `@wrap_as_background_process` -> `run_as_background_process` …
MadLittleMods b6d65bf
Update `@wrap_as_background_process` to match `@measure_func` pattern…
MadLittleMods 7aace77
Bulk fill in `self.server_name` for `@wrap_as_background_process`
MadLittleMods dba6d75
Fire and forget `generate_monthly_active_users`
MadLittleMods 56b470b
Fix fire and forget conversions
MadLittleMods 12c4323
Try fix `defer.Deferred[None]` -> `TypeError: 'type' object is not su…
MadLittleMods 0610810
Fix type and align with fire and forget pattern
MadLittleMods 8830c21
Remove debug log
MadLittleMods 2dddd06
Merge branch 'develop' into madlittlemods/18592-background-process-me…
MadLittleMods f0ee141
Fix `server_name` missing in `RedisSubscriber` (complexity)
MadLittleMods 775503a
Merge branch 'develop' into madlittlemods/18592-background-process-me…
MadLittleMods b512c37
No need to store the sentinel context
MadLittleMods 6b77f63
Fill in `server_name` for the new thread subscriptions `MultiWriterId…
MadLittleMods 0a8a6bb
Merge branch 'develop' into madlittlemods/18592-background-process-me…
MadLittleMods File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Refactor background process metrics to be homeserver-scoped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
@wrap_as_background_process
was updated to takeself.server_name
, we've had to refactor a few of the calls that don't useself
.Should be equivalent to before.