Skip to content

Minor improvements to README.rst #18700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 30, 2025
Merged

Minor improvements to README.rst #18700

merged 11 commits into from
Jul 30, 2025
+20 −20

Conversation

escix
Copy link
Contributor

@escix escix commented Jul 19, 2025

Minor improvements.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

escix added 2 commits July 19, 2025 11:58
@escix
Update README.rst
9bbdc7c 
Minor improvements.
@escix
Create 18700.misc
0bbbac5 
Minor improvements to README.
@escix escix changed the title Update README.rst Minor improvements to README.rst Jul 19, 2025
@escix escix marked this pull request as ready for review July 19, 2025 02:13
@escix escix requested a review from a team as a code owner July 19, 2025 02:13
escix added 2 commits July 19, 2025 13:00
@escix
Minor improvements to comments build_rust.py
84f325e 
Minor improvements to comments build_rust.py
@escix
Update README.rst
69f6a3f
anoadragon453
anoadragon453 requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A few small changes, but otherwise I'm happy.

@escix escix requested a review from anoadragon453 July 23, 2025 22:04
@anoadragon453
Copy link
Member

@escix it seems you resolved the suggestions without applying them. What that on purpose? 😄

escix and others added 2 commits July 25, 2025 18:06
@escix @anoadragon453
Update README.rst
8bb4cd6 
Co-authored-by: Andrew Morgan <[email protected]>
@escix @anoadragon453
Update README.rst
62479f9 
Co-authored-by: Andrew Morgan <[email protected]>
@escix
Copy link
Contributor Author

escix commented Jul 25, 2025

@escix it seems you resolved the suggestions without applying them. What that on purpose? 😄

Sorry mate, I am new to all of these. Hopefully it is all good now.
Thanks for your patience.

anoadragon453
anoadragon453 approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! This now looks good to me. Thanks for your contribution!

@anoadragon453 anoadragon453 merged commit 8637097 into element-hq:develop Jul 30, 2025
32 checks passed
anoadragon453 added a commit that referenced this pull request Jul 30, 2025
@anoadragon453
Fix trailing whitespace in build_rust.py, from #18700
25289b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escix @anoadragon453