-
Notifications
You must be signed in to change notification settings - Fork 404
Always treat RETURNING as supported by SQL engines
#19047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Always treat RETURNING as supported by SQL engines
#19047
Conversation
Can do this now that SQLite 3.40 supports RETURNING
|
seems good, CI is failing though (maybe a missed usage of |
as bookworm is what bumped libsqlite
| if sqlite3.sqlite_version_info < (3, 40, 0): | ||
| raise RuntimeError("Synapse requires sqlite 3.40 or above.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs the Sytest image to install SQLite >=3.40.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing from the review queue while we wait for Sytest PR's to merge and CI to get green.
as it isn't all that relevant, and must be kept up to date. Implicitly trust that the synapse-sytest image uses an appropriate Python version.
Can do this now that SQLite 3.40 supports
RETURNING.This also bumps the minimum suppoted SQLite version according to Synapse's deprecation policy.
Addresses #17577
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.