Fix indentation of sighup handler calling code #19060
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The impact of the bug was that `READY=1` would never be signaled to systemd. This meant that any `reload` command sent via systemd would lock the process into a permanent `reloading` state, meaning it could not be `reload`ed again until the service was restarted. This could cause operational issues when the processes needed to be reloaded multiple times.
sandhose
approved these changes
Oct 14, 2025
|
CI failures are unrelated to this PR. |
| @@ -0,0 +1 @@ | |||
| Fix a bug introduced in 1.136.0 that would prevent Synapse from being able to be `reload`-ed more than once when running under systemd. No newline at end of file | |||
There was a problem hiding this comment.
Is there a way we can add a test for this? To prevent future breakage and ensure this behavior works into the future.
Perhaps our first out-of-repo Complement test that lives in the Synapse project. For example, we already do SIGHUP stuff in the SBG Complement tests.
There was a problem hiding this comment.
I see no reason not to do that, though it would be a good amount of work to set up the CI and write such a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impact of the bug was that
READY=1would never be signaled to systemd. This meant that anyreloadcommand sent via systemd would lock the process into a permanentreloadingstate, meaning it could not bereloaded again until the service was restarted.This could cause operational issues when the processes needed to be reloaded multiple times.
Broke in #18670.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.