Sidebar Gtk4 Prep #2287
Merged
Sidebar Gtk4 Prep #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
danirabbit
commented
Aug 15, 2023
jeremypw
requested changes
Aug 16, 2023
Contributor
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
You can reduce the diff by reverting changes to the clear () function. Otherwise everything seems to work as before.
Contributor
|
Holding until after release of version 6.5.0 |
jeremypw
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting over based on changes from #2082
I think this is The Least™ to make sure these don't subclass ListBox without any errors or warnings in terminal etc
SidebarInterface,SidebarWindowremove_item_by_idSidebarItemInterfaceSidebarListInterfaceremove_bookmark_by_uriGtk.ListBoxRowinstead ofSidebarItemInterfacewhere possible to avoid issues with pointers/castingBookmarkListBox,DeviceListBox,NetworkListBoxGtk.ListBoxRowinstead ofSidebarItemInterfacewhere possible to avoid issues with pointers/casting