Skip to content

Conversation

@jeremypw
Copy link
Contributor

@jeremypw jeremypw commented Nov 2, 2025

Fixes #1278

BEFORE

Screenshot from 2025-11-03 09 28 38

AFTER

  • Completely empty folder
Screenshot from 2025-11-08 19 21 45
  • Only hidden files
Screenshot from 2025-11-08 19 22 01

@jeremypw jeremypw marked this pull request as ready for review November 3, 2025 09:35
@jeremypw jeremypw added this to the 7.2.0 milestone Nov 3, 2025
@jeremypw jeremypw requested a review from a team November 3, 2025 11:08
@jeremypw jeremypw mentioned this pull request Nov 7, 2025
3 tasks
@teamcons
Copy link

teamcons commented Nov 7, 2025

if we mention hidden files we may as well straight up display a button to show them, instead of "lol go find it yourself" ?

@jeremypw
Copy link
Contributor Author

jeremypw commented Nov 8, 2025

@danirabbit What is your opinion of adding a "Show Hidden" button in this context?

@jeremypw
Copy link
Contributor Author

jeremypw commented Nov 8, 2025

OK, so should it change the global setting or just reveal the hidden files for the folder in question?

@teamcons
Copy link

teamcons commented Nov 8, 2025

A one-time "display this folder" that lasts only till you change folder could be nice

@jeremypw
Copy link
Contributor Author

jeremypw commented Nov 8, 2025

That would be possible. My only concern is that there would be no obvious way to revert the step without reloading or navigating away from the folder (the appmenu and context menu would still show hidden files are not shown). Its not a big deal though I guess.

@jeremypw
Copy link
Contributor Author

jeremypw commented Nov 8, 2025

@teamcons Latest commit implements a basic implementation of you idea. Instead of having two labels, there are now only one showing at any time - corresponding to the two relevant situations. I have also avoided the words "Empty Folder" as it is rather ambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore hidden files for 'this folder is empty' message

3 participants