Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2658 - hopefully.
The first four commits are basically cleanup and can be ignored or split out into a separate PR.
The final commit reworks and slightly simplifies deciding whether a file can be dropped and now ignores the selected action from
DragContext.get_selected_action ()as it seems that this is now unreliable on Wayland and may return 'null' or some other value which is not a valid DragAction.As a consequence of this, dropping a file onto its parent now results in a menu allowing choice between COPY and LINK actions. This is parallel to the paste options on the context menu when using the keyboard. If desired this can be easily reverted to defaulting to refusing the drop.
TODO