Merged
Conversation
We guarantee for every START to get an END so make sure we actually can guarantee it.
A propagation of a commit can cause the user of the controller to call goto which then sets a timeline. However that timeline would be overwritten again when we set the timeline after the commit.
lenemter
approved these changes
Mar 6, 2026
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
I can't reproduce the issue but code LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if there are any current reproducers for this (there might very well be some because it's a valid use case for the gesture controller) but before #2694 (still happens if you revert the commit) this happened when you had
Now you're stuck.
It only happened because our move to new workspace behavior was a bit buggy before #2694 but what it triggered is a valid use case of the controller so we should be able to handle it.
This PR does that and adds a safeguard.
See the commit messages for some reasoning.