UserSettingsView: use switch for locking account#259
Open
danirabbit wants to merge 8 commits intomainfrom
Open
UserSettingsView: use switch for locking account#259danirabbit wants to merge 8 commits intomainfrom
danirabbit wants to merge 8 commits intomainfrom
Conversation
ryonakano
reviewed
Oct 20, 2025
Comment on lines
+115
to
+117
| disable_switch = new Gtk.Switch () { | ||
| action_name = "user.enable", | ||
| tooltip_text = _("Account Lock"), |
Member
There was a problem hiding this comment.
Shouldn't this be named as something like lock_switch or at least enable_switch then?
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be rebase merged if desired