You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removing tuple_dnf_union in tuple_eliminate_single_negation is fine because tuple_elim_size(n, m, tag, elements, neg_tag) and tuple_elim_content([], tag, elements, neg_elements) generate
tuples of different sizes, so they are disjoint.
But once tuple_bdd_to_dnf_no_negations/1 no longer unions the generated lines, different BDD lines can produce structural duplicates. That is semantically fine, but it can regress singleton?/1, because each_singleton?(:tuple, bdd) expects the DNF to contain exactly one tuple line for a singleton. I put an example of that.
So I think we should keep the optimization inside tuple_eliminate_single_negation, but still deduplicate at the final no-negations DNF boundary (via Enum.uniq()). An alternative is to do it directly in each_singleton(:tuple, bdd).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.